Just looking at JAL-1853, I noticed that my workspace showed no warning for unused parameter in AlignmentView
private SequenceI[] getVisibleSeqs(int c)
I tracked this down to ‘Ignore unused parameters documented with @param tag’ being selected in Eclipse preferences.
This gives no warning (as long as the parameter name matches the name in the @param tag!).
I think I’ll untick this. Unused variable warnings are very useful when QA’ing code (would have prevented this bug).
The constructor of this class has a couple!
Thinking broader, I would love to get to the point where the whole codebase shows minimal (and justifiable) warnings (including any code metrics / Checkstyle / Findbugs rules we ever adopt).
A distant dream at the moment I realise.
Mungo
The University of Dundee is a registered Scottish Charity, No: SC015096
···
Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
School of Life Sciences
University of Dundee, Dundee, Scotland, UK.
www.jalview.org
www.compbio.dundee.ac.uk