Import ordering in code

Hi Mungo, and all.

You (and Tochukwu) are ordering like:
java
javax
org
com
jalview

I now realise I was the odd-one out. However, I do have strong opinions about this ordering, having jalview imports first will make things infinitely easier when we carve up the packages into separate OSGi modules.

So may I respectfully ask that we put jalview packages at the top ? I'm happy for us to do this when we scrub the 2.9 code, rather than right now, to avoid unnecessary conflicts (until then, I'll use your ordering, Mungo).

Jim.

···

On 05/06/2015 11:46, Mungo Carstairs (Staff) wrote:

Looks like we don't quite have consistency yet which will result in unnecessary diffs with each commit.

I have this:

<image removed>

Does that seem a reasonable ordering, if so can we all configure the same?

Happy to switch to
jalview
java
javax
org
com

Just say when we're ready to do so!

mungo

Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
www.jalview.org
www.compbio.dundee.ac.uk

···

________________________________________
From: jalview-dev-bounces@jalview.org <jalview-dev-bounces@jalview.org> on behalf of Jim Procter <jprocter@compbio.dundee.ac.uk>
Sent: 11 June 2015 12:11
To: Jalview Development List
Subject: Re: [Jalview-dev] Import ordering in code

Hi Mungo, and all.

You (and Tochukwu) are ordering like:
java
javax
org
com
jalview

I now realise I was the odd-one out. However, I do have strong opinions
about this ordering, having jalview imports first will make things
infinitely easier when we carve up the packages into separate OSGi modules.

So may I respectfully ask that we put jalview packages at the top ? I'm
happy for us to do this when we scrub the 2.9 code, rather than right
now, to avoid unnecessary conflicts (until then, I'll use your ordering,
Mungo).

Jim.

On 05/06/2015 11:46, Mungo Carstairs (Staff) wrote:

Looks like we don't quite have consistency yet which will result in
unnecessary diffs with each commit.

I have this:

<image removed>

Does that seem a reasonable ordering, if so can we all configure the same?

_______________________________________________
Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096

Same with me. Happy to switch anytime.

Charles

Ofoegbu Tochukwu Charles
Jalview Visual Analytics Developer/Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
Skype: cofoegbu
www.jalview.org
www.compbio.dundee.ac.uk

···

On 11 Jun 2015, at 12:17 pm, Mungo Carstairs (Staff) <g.m.carstairs@dundee.ac.uk> wrote:

Happy to switch to
jalview
java
javax
org
com

Just say when we’re ready to do so!

mungo

Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
www.jalview.org
www.compbio.dundee.ac.uk


From: jalview-dev-bounces@jalview.org jalview-dev-bounces@jalview.org on behalf of Jim Procter jprocter@compbio.dundee.ac.uk
Sent: 11 June 2015 12:11
To: Jalview Development List
Subject: Re: [Jalview-dev] Import ordering in code

Hi Mungo, and all.

You (and Tochukwu) are ordering like:
java
javax
org
com
jalview

I now realise I was the odd-one out. However, I do have strong opinions
about this ordering, having jalview imports first will make things
infinitely easier when we carve up the packages into separate OSGi modules.

So may I respectfully ask that we put jalview packages at the top ? I’m
happy for us to do this when we scrub the 2.9 code, rather than right
now, to avoid unnecessary conflicts (until then, I’ll use your ordering,
Mungo).

Jim.

On 05/06/2015 11:46, Mungo Carstairs (Staff) wrote:

Looks like we don’t quite have consistency yet which will result in
unnecessary diffs with each commit.

I have this:

Does that seem a reasonable ordering, if so can we all configure the same?


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096

OK. The perfect time is when all in-progress feature branches are merged (since develop currently has the other ordering), but if you want to switch now, then that's fine too.

I guess I'll keep using the jalview on top ordering then !
Jim

···

On 11/06/2015 12:23, Charles Ofoegbu (Staff) wrote:

Same with me. Happy to switch anytime.

Charles

Ofoegbu Tochukwu Charles
Jalview Visual Analytics Developer/Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
Skype: cofoegbu
www.jalview.org <http://www.jalview.org/>
www.compbio.dundee.ac.uk <http://www.compbio.dundee.ac.uk/>​

On 11 Jun 2015, at 12:17 pm, Mungo Carstairs (Staff) > <g.m.carstairs@dundee.ac.uk <mailto:g.m.carstairs@dundee.ac.uk>> wrote:

Happy to switch to
jalview
java
javax
org
com

Just say when we're ready to do so!

mungo

Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
www.jalview.org <http://www.jalview.org>
www.compbio.dundee.ac.uk

________________________________________
From: jalview-dev-bounces@jalview.org <jalview-dev-bounces@jalview.org> on behalf of Jim Procter <jprocter@compbio.dundee.ac.uk>
Sent: 11 June 2015 12:11
To: Jalview Development List
Subject: Re: [Jalview-dev] Import ordering in code

Hi Mungo, and all.

You (and Tochukwu) are ordering like:
java
javax
org
com
jalview

I now realise I was the odd-one out. However, I do have strong opinions
about this ordering, having jalview imports first will make things
infinitely easier when we carve up the packages into separate OSGi modules.

So may I respectfully ask that we put jalview packages at the top ? I'm
happy for us to do this when we scrub the 2.9 code, rather than right
now, to avoid unnecessary conflicts (until then, I'll use your ordering,
Mungo).

Jim.

On 05/06/2015 11:46, Mungo Carstairs (Staff) wrote:

Looks like we don't quite have consistency yet which will result in
unnecessary diffs with each commit.

I have this:

<image removed>

Does that seem a reasonable ordering, if so can we all configure the same?

_______________________________________________
Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096
_______________________________________________
Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096

_______________________________________________
Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

Can I attach documents to this list? I have bullet points for what is needed in terms of Java preparation for J2S.

···

On Thu, Jun 11, 2015 at 6:40 AM, Jim Procter <jprocter@compbio.dundee.ac.uk> wrote:

OK. The perfect time is when all in-progress feature branches are merged
(since develop currently has the other ordering), but if you want to
switch now, then that’s fine too.

I guess I’ll keep using the jalview on top ordering then !
Jim

On 11/06/2015 12:23, Charles Ofoegbu (Staff) wrote:

Same with me. Happy to switch anytime.

Charles

Ofoegbu Tochukwu Charles
Jalview Visual Analytics Developer/Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
Skype: cofoegbu
www.jalview.org <http://www.jalview.org/>
www.compbio.dundee.ac.uk <http://www.compbio.dundee.ac.uk/>​

On 11 Jun 2015, at 12:17 pm, Mungo Carstairs (Staff)
<g.m.carstairs@dundee.ac.uk mailto:[g.m.carstairs@dundee.ac.uk](mailto:g.m.carstairs@dundee.ac.uk)> wrote:

Happy to switch to
jalview
java
javax
org
com

Just say when we’re ready to do so!

mungo

Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
College of Life Sciences
University of Dundee, Dundee, Scotland, UK.
www.jalview.org <http://www.jalview.org>

www.compbio.dundee.ac.uk


From: jalview-dev-bounces@jalview.org
<jalview-dev-bounces@jalview.org> on behalf of Jim Procter
<jprocter@compbio.dundee.ac.uk>
Sent: 11 June 2015 12:11
To: Jalview Development List
Subject: Re: [Jalview-dev] Import ordering in code

Hi Mungo, and all.

You (and Tochukwu) are ordering like:
java
javax
org
com
jalview

I now realise I was the odd-one out. However, I do have strong opinions
about this ordering, having jalview imports first will make things
infinitely easier when we carve up the packages into separate OSGi
modules.

So may I respectfully ask that we put jalview packages at the top ? I’m
happy for us to do this when we scrub the 2.9 code, rather than right
now, to avoid unnecessary conflicts (until then, I’ll use your ordering,
Mungo).

Jim.

On 05/06/2015 11:46, Mungo Carstairs (Staff) wrote:

Looks like we don’t quite have consistency yet which will result in
unnecessary diffs with each commit.

I have this:

Does that seem a reasonable ordering, if so can we all configure the
same?


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

The University of Dundee is a registered Scottish Charity, No: SC015096


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

Robert M. Hanson
Larson-Anderson Professor of Chemistry
Chair, Department of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr

If nature does not answer first what we want,
it is better to take what answer we get.

– Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900

Can I attach documents to this list? I have bullet points for what is needed in terms of Java preparation for J2S.

Probably best to log in to issues.jalview.org and attach it to http://issues.jalview.org/browse/JAL-1758

Jim

···

On 11/06/2015 13:29, Robert Hanson wrote:

I decided to put this on the SwingJS wiki. It’s a full accounting of identified issues.

https://sourceforge.net/p/swingjs/wiki/Java-To-JavaScript%20Considerations/

···

On Thu, Jun 11, 2015 at 8:46 AM, James Procter <j.procter@dundee.ac.uk> wrote:

On 11/06/2015 13:29, Robert Hanson wrote:

Can I attach documents to this list? I have bullet points for what is needed in terms of Java preparation for J2S.

Probably best to log in to issues.jalview.org and attach it to http://issues.jalview.org/browse/JAL-1758

Jim


Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

Robert M. Hanson
Larson-Anderson Professor of Chemistry
Chair, Department of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr

If nature does not answer first what we want,
it is better to take what answer we get.

– Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900

Awesome! Thanks. We can generate a TODO from this.

Jim.

···

On 11/06/2015 14:57, Robert Hanson wrote:

I decided to put this on the SwingJS wiki. It's a full accounting of identified issues.

https://sourceforge.net/p/swingjs/wiki/Java-To-JavaScript%20Considerations/