Sounds like it could be an effect of my out-by-one fixes. I’ll have a look.
Kira
···
From: jalview-dev-bounces@jalview.org on behalf of “Mungo Carstairs (Staff)” g.m.carstairs@dundee.ac.uk
Reply-To: Jalview Development List jalview-dev@jalview.org
Date: Monday, 24 April 2017 at 10:34
To: Jalview Development List jalview-dev@jalview.org
Subject: [Jalview-dev] Hidden columns marker
I’ve just noticed that in dev (but not in 2.10.1) the vertical blue line marking hidden columns is coming up short (doesn’t reach the last row).
Anyone got a clue why that might be?
mungo
Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
School of Life Sciences
University of Dundee, Dundee, Scotland, UK
www.jalview.org
www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017
The University of Dundee is a registered Scottish Charity, No: SC015096
Fixed and pushed to develop.
Kira
···
From: jalview-dev-bounces@jalview.org on behalf of “Kira Mourao (Staff)” k.mourao@dundee.ac.uk
Reply-To: Jalview Development List jalview-dev@jalview.org
Date: Monday, 24 April 2017 at 10:36
To: Jalview Development List jalview-dev@jalview.org
Subject: Re: [Jalview-dev] Hidden columns marker
Sounds like it could be an effect of my out-by-one fixes. I’ll have a look.
Kira
From: jalview-dev-bounces@jalview.org on behalf of “Mungo Carstairs (Staff)” g.m.carstairs@dundee.ac.uk
Reply-To: Jalview Development List jalview-dev@jalview.org
Date: Monday, 24 April 2017 at 10:34
To: Jalview Development List jalview-dev@jalview.org
Subject: [Jalview-dev] Hidden columns marker
I’ve just noticed that in dev (but not in 2.10.1) the vertical blue line marking hidden columns is coming up short (doesn’t reach the last row).
Anyone got a clue why that might be?
mungo
Mungo Carstairs
Jalview Computational Scientist
The Barton Group
Division of Computational Biology
School of Life Sciences
University of Dundee, Dundee, Scotland, UK
www.jalview.org
www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017
The University of Dundee is a registered Scottish Charity, No: SC015096
The University of Dundee is a registered Scottish Charity, No: SC015096
Thanks for fixing, Kira.
Mungo wrote:
I've just noticed that in dev (but not in 2.10.1) the vertical blue line
marking hidden columns is coming up short (doesn't reach the last row).
Anyone got a clue why that might be?
I'm curious. Why didn't the test fail for this ? I thought we'd covered
the hidden column marker check when the Alignment ruler code was revised.
sigh.
j.--
···
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | www.jalview.org | www.compbio.dundee.ac.uk
It was the length of the line drawn from the column marker that was too short, rather than the marker itself being in the wrong position. I imagine that was not covered in the ruler code?
Kira
Thanks for fixing, Kira.
Mungo wrote:
> I've just noticed that in dev (but not in 2.10.1) the vertical blue line
> marking hidden columns is coming up short (doesn't reach the last row).
>
> Anyone got a clue why that might be?
I'm curious. Why didn't the test fail for this ? I thought we'd covered
the hidden column marker check when the Alignment ruler code was revised.
sigh.
j.--
···
On 24/04/2017, 11:24, "jalview-dev-bounces@jalview.org on behalf of James Procter" <jalview-dev-bounces@jalview.org on behalf of j.procter@dundee.ac.uk> wrote:
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | www.jalview.org | www.compbio.dundee.ac.uk
_______________________________________________
Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev
The University of Dundee is a registered Scottish Charity, No: SC015096
heh. definitely not - that's the alignment cavas renderer code 
Happy we didn't have a hole in the tests!
j.
···
On 24/04/2017 11:29, Kira Mourao (Staff) wrote:
It was the length of the line drawn from the column marker that was too short, rather than the marker itself being in the wrong position. I imagine that was not covered in the ruler code?
--
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | www.jalview.org | www.compbio.dundee.ac.uk