Help - build failing

Jalview Developers
1

spike-mungo has started failing with an error

/opt/homes/cruisecontrol/live/cruisecontrol/checkout/spike-mungo/src/jalview/gui/FeatureSettings.java:1510: 

error: cannot find symbol
class FeatureTableModel extends AbstractTableModel
^
symbol:   class AbstractTableModel
location: class FeatureSettings



which is baffling me as it compiles ok in Eclipse (or Ant makedist), and I can't think what has materially changed here.

AbstractTableModel is in javax.swing.table so should be found.



Any ideas anyone?



thanks,



Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

···

Email signature

University of Dundee shield logo

Mungo Carstairs
Jalview Computational Scientist

The Barton Group
Division of Computational Biology

School of Life Sciences

University of Dundee, Dundee, Scotland, UK

www.jalview.org

www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk

University of Dundee FacebookUniversity of Dundee TwitterUniversity of Dundee LinkedInUniversity of Dundee YouTubeUniversity of Dundee InstagramUniversity of Dundee Snapchat
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017

2

Looks like a merge issue. Will take a look for the morning…

···

On Thu, Nov 23, 2017, 4:50 PM Mungo Carstairs (Staff) <g.m.carstairs@dundee.ac.uk> wrote:

spike-mungo has started failing with an error

/opt/homes/cruisecontrol/live/cruisecontrol/checkout/spike-mungo/src/jalview/gui/FeatureSettings.java:1510: 

error: cannot find symbol
class FeatureTableModel extends AbstractTableModel
^
symbol:   class AbstractTableModel
location: class FeatureSettings



which is baffling me as it compiles ok in Eclipse (or Ant makedist), and I can't think what has materially changed here.

AbstractTableModel is in javax.swing.table so should be found.



Any ideas anyone?



thanks,



Mungo

Email signature

University of Dundee shield logo

Mungo Carstairs
Jalview Computational Scientist

The Barton Group
Division of Computational Biology

School of Life Sciences

University of Dundee, Dundee, Scotland, UK

www.jalview.org

www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk

University of Dundee FacebookUniversity of Dundee TwitterUniversity of Dundee LinkedInUniversity of Dundee YouTubeUniversity of Dundee InstagramUniversity of Dundee Snapchat
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017

The University of Dundee is a registered Scottish Charity, No: SC015096

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

3

Obscure javac/linux bug (it seems).

I patched src/jalview/gui/FeatureSettings.java like below and it compiled. Possibly a similar issue to https://github.com/rzwitserloot/lombok/issues/1249 …

diff --git a/src/jalview/gui/FeatureSettings.java b/src/jalview/gui/FeatureSettings.java
index 0c4cd56…7223df6 100644
— a/src/jalview/gui/FeatureSettings.java
+++ b/src/jalview/gui/FeatureSettings.java
@@ -20,11 +20,6 @@
*/
package jalview.gui;

-import static jalview.gui.FeatureSettings.FeatureTableModel.COLOUR_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.FILTER_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.SHOW_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.TYPE_COLUMN;

···

On 23/11/2017 19:49, Jim Procter wrote:

-- 
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | [www.jalview.org](http://www.jalview.org) | [www.compbio.dundee.ac.uk](http://www.compbio.dundee.ac.uk)
4

Even worse… http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7101822

so import order matters in this case ! yuk.

j.

···

On 24/11/2017 13:45, Jim Procter wrote:

On 23/11/2017 19:49, Jim Procter wrote:

-- 
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | [www.jalview.org](http://www.jalview.org) | [www.compbio.dundee.ac.uk](http://www.compbio.dundee.ac.uk)


-- 
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | [www.jalview.org](http://www.jalview.org) | [www.compbio.dundee.ac.uk](http://www.compbio.dundee.ac.uk)
5

Well spotted Jim. I have updated the spike with the constants relocated as suggested, hopefully it will be happy this time.

thanks,

Mungo

···

Email signature

University of Dundee shield logo

Mungo Carstairs
Jalview Computational Scientist

The Barton Group
Division of Computational Biology

School of Life Sciences

University of Dundee, Dundee, Scotland, UK

www.jalview.org

www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk

University of Dundee FacebookUniversity of Dundee TwitterUniversity of Dundee LinkedInUniversity of Dundee YouTubeUniversity of Dundee InstagramUniversity of Dundee Snapchat
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017

From: jalview-dev-bounces@jalview.org jalview-dev-bounces@jalview.org on behalf of Jim Procter jprocter@compbio.dundee.ac.uk
Sent: 24 November 2017 13:48:20
To: jalview-dev@jalview.org
Subject: Re: [Jalview-dev] Help - build failing

Even worse… http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7101822

so import order matters in this case ! yuk.

j.

On 24/11/2017 13:45, Jim Procter wrote:

Obscure javac/linux bug (it seems).

I patched src/jalview/gui/FeatureSettings.java like below and it compiled. Possibly a similar issue to https://github.com/rzwitserloot/lombok/issues/1249 …

diff --git a/src/jalview/gui/FeatureSettings.java b/src/jalview/gui/FeatureSettings.java
index 0c4cd56…7223df6 100644
— a/src/jalview/gui/FeatureSettings.java
+++ b/src/jalview/gui/FeatureSettings.java
@@ -20,11 +20,6 @@
*/
package jalview.gui;

-import static jalview.gui.FeatureSettings.FeatureTableModel.COLOUR_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.FILTER_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.SHOW_COLUMN;
-import static jalview.gui.FeatureSettings.FeatureTableModel.TYPE_COLUMN;

import jalview.api.FeatureColourI;
import jalview.api.FeatureSettingsControllerI;
import jalview.bin.Cache;
@@ -115,6 +110,16 @@ public class FeatureSettings extends JPanel
private static final int MIN_WIDTH = 400;

private static final int MIN_HEIGHT = 400;

  • /*
    • column indices of fields in Feature Settings table
  • */
  • static final int TYPE_COLUMN = 0;
  • static final int COLOUR_COLUMN = 1;
  • static final int FILTER_COLUMN = 2;
  • static final int SHOW_COLUMN = 3;

DasSourceBrowser dassourceBrowser;

@@ -1509,16 +1514,6 @@ public class FeatureSettings extends JPanel
// ///////////////////////////////////////////////////////////////////////
class FeatureTableModel extends AbstractTableModel
{

  • /*
    • column indices of fields in Feature Settings table
  • */
  • static final int TYPE_COLUMN = 0;
  • static final int COLOUR_COLUMN = 1;
  • static final int FILTER_COLUMN = 2;
  • static final int SHOW_COLUMN = 3;

On 23/11/2017 19:49, Jim Procter wrote:

Looks like a merge issue. Will take a look for the morning…

On Thu, Nov 23, 2017, 4:50 PM Mungo Carstairs (Staff) <g.m.carstairs@dundee.ac.uk> wrote:

spike-mungo has started failing with an error

/opt/homes/cruisecontrol/live/cruisecontrol/checkout/spike-mungo/src/jalview/gui/FeatureSettings.java:1510: 

error: cannot find symbol
class FeatureTableModel extends AbstractTableModel
^
symbol:   class AbstractTableModel
location: class FeatureSettings

which is baffling me as it compiles ok in Eclipse (or Ant makedist), and I can't think what has materially changed here.

AbstractTableModel is in javax.swing.table so should be found.

Any ideas anyone?

thanks,

Mungo

Email signature

University of Dundee shield logo

Mungo Carstairs
Jalview Computational Scientist

The Barton Group
Division of Computational Biology

School of Life Sciences

University of Dundee, Dundee, Scotland, UK

www.jalview.org

www.compbio.dundee.ac.uk
g.m.carstairs@dundee.ac.uk

University of Dundee FacebookUniversity of Dundee TwitterUniversity of Dundee LinkedInUniversity of Dundee YouTubeUniversity of Dundee InstagramUniversity of Dundee Snapchat
We’re Scottish University of the Year again!
The Times / Sunday Times Good University Guide 2016 and 2017

The University of Dundee is a registered Scottish Charity, No: SC015096

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

_______________________________________________
Jalview-dev mailing list
[Jalview-dev@jalview.org](mailto:Jalview-dev@jalview.org)
[http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev](http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev)


-- 
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | [www.jalview.org](http://www.jalview.org) | [www.compbio.dundee.ac.uk](http://www.compbio.dundee.ac.uk)


_______________________________________________
Jalview-dev mailing list
[Jalview-dev@jalview.org](mailto:Jalview-dev@jalview.org)
[http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev](http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev)


-- 
-------------------------------------------------------------------
Dr JB Procter, Jalview Coordinator, The Barton Group
Division of Computational Biology, School of Life Sciences
University of Dundee, Dundee DD1 5EH, UK.
+44 1382 388734 | [www.jalview.org](http://www.jalview.org) | [www.compbio.dundee.ac.uk](http://www.compbio.dundee.ac.uk)

The University of Dundee is a registered Scottish Charity, No: SC015096