Changes ready for test

Jalview Developers
1

​For Jim,

These have been pushed to branch features/JAL-1264…

JAL-1264 show/hide annotation types

JAL-914 don’t open Help window twice

JAL-1481 warning on invalid regular expression for sequence search

JAL-1506 warning on delete all sequences

I have a ton of unit tests to add for JAL-1264, these will follow.

Thanks

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

2

hi guys,
If you tell me how to test this from UI, it will be a pleasure for me to help.
Cheers,
David

···

El 03/10/2014 13:12, “Mungo Carstairs” <g.m.carstairs@dundee.ac.uk> escribió:

​For Jim,

These have been pushed to branch features/JAL-1264…

JAL-1264 show/hide annotation types

JAL-914 don’t open Help window twice

JAL-1481 warning on invalid regular expression for sequence search

JAL-1506 warning on delete all sequences

I have a ton of unit tests to add for JAL-1264, these will follow.

Thanks

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

3

Hi David.

typically, the jira links should give you all the info on how to test something. In this case, however, mungo pushed a bunch of stuff and I’m now testing and cherry-picking Mungo’s branch for integration. The annotation show/hide feature (which were the main reason for his push) is not quite alpha yet - since we’re working out how the UI should look, so I shouldn’t worry at the mo.

You could take a look at the i18n patches that I pushed yesterday, though. I’ve made some comments including/excluding top level html tags in i18n text to minimise chances of introducing malformed html…

Jim

···

On 03/10/2014 18:28, David Roldán Martínez wrote:

4

Great!!! I’ll do the test during this week. If I find something wrong, do you want me to generate a patch or directly commit and push changes on Branch_2_8_2?

– David

···

2014-10-04 18:18 GMT+02:00 Jim Procter <jprocter@compbio.dundee.ac.uk>:

Hi David.

typically, the jira links should give you all the info on how to test something. In this case, however, mungo pushed a bunch of stuff and I’m now testing and cherry-picking Mungo’s branch for integration. The annotation show/hide feature (which were the main reason for his push) is not quite alpha yet - since we’re working out how the UI should look, so I shouldn’t worry at the mo.

You could take a look at the i18n patches that I pushed yesterday, though. I’ve made some comments including/excluding top level html tags in i18n text to minimise chances of introducing malformed html…

Jim

On 03/10/2014 18:28, David Roldán Martínez wrote:

hi guys,
If you tell me how to test this from UI, it will be a pleasure for me to help.
Cheers,
David

El 03/10/2014 13:12, “Mungo Carstairs” <g.m.carstairs@dundee.ac.uk> escribió:

​For Jim,

These have been pushed to branch features/JAL-1264…

JAL-1264 show/hide annotation types

JAL-914 don’t open Help window twice

JAL-1481 warning on invalid regular expression for sequence search

JAL-1506 warning on delete all sequences

I have a ton of unit tests to add for JAL-1264, these will follow.

Thanks

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

_______________________________________________
Jalview-dev mailing list
[Jalview-dev@jalview.org](mailto:Jalview-dev@jalview.org)
[http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev](http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev)

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

5

My two cents,

  1. i18n changes seems no to be merged. :frowning:

  2. I’ve switched Release_2_8_2_Brach and tested JAL-1506. I’m getting an exception, not a warning dialog (please, see my comments at the ticket). However, I’m sure if this is the right branch I have to test.

Cheers,

David

···

2014-10-05 9:40 GMT+02:00 David Roldán Martínez <darolmar@gmail.com>:

Great!!! I’ll do the test during this week. If I find something wrong, do you want me to generate a patch or directly commit and push changes on Branch_2_8_2?

– David

2014-10-04 18:18 GMT+02:00 Jim Procter <jprocter@compbio.dundee.ac.uk>:

Hi David.

typically, the jira links should give you all the info on how to test something. In this case, however, mungo pushed a bunch of stuff and I’m now testing and cherry-picking Mungo’s branch for integration. The annotation show/hide feature (which were the main reason for his push) is not quite alpha yet - since we’re working out how the UI should look, so I shouldn’t worry at the mo.

You could take a look at the i18n patches that I pushed yesterday, though. I’ve made some comments including/excluding top level html tags in i18n text to minimise chances of introducing malformed html…

Jim

On 03/10/2014 18:28, David Roldán Martínez wrote:

hi guys,
If you tell me how to test this from UI, it will be a pleasure for me to help.
Cheers,
David

El 03/10/2014 13:12, “Mungo Carstairs” <g.m.carstairs@dundee.ac.uk> escribió:

​For Jim,

These have been pushed to branch features/JAL-1264…

JAL-1264 show/hide annotation types

JAL-914 don’t open Help window twice

JAL-1481 warning on invalid regular expression for sequence search

JAL-1506 warning on delete all sequences

I have a ton of unit tests to add for JAL-1264, these will follow.

Thanks

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

_______________________________________________
Jalview-dev mailing list
[Jalview-dev@jalview.org](mailto:Jalview-dev@jalview.org)
[http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev](http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev)

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

6

Hello David.

1. i18n changes seems no to be merged. :frowning:

hmm... really?
My merge seems to have taken, so the more complete spanish translation is in both branches now.

http://source.jalview.org/gitweb/?p=jalview.git;a=shortlog;h=refs/heads/Release_2_8_2_Branch_i18n
http://source.jalview.org/gitweb/?p=jalview.git;a=shortlog;h=refs/heads/Release_2_8_2_Branch

2. I've switched Release_2_8_2_Brach and tested JAL-1506. I'm getting an exception, not a warning dialog (please, see my comments at the ticket). However, I'm sure if this is the right branch I have to test.

David - you needed to switch to the branch where Mungo pushed his changes for review. However, as I said in the previous email - I'm reviewing and merging these in, so you don't need to do anything yet.

Jim

···

On 06/10/2014 18:31, David Roldán Martínez wrote:

7

OK. It was my fault. I made a fetch but not pull and that’s why my local copy was out of date.

I’ve reviewed i18n and everything seems to be ok. As for translations, I’ll ping volunteers to check the status. At least for the Spanish one, if Ipek hasn’t found the time to do it, I’ll do it on my own so that we can arrive the release with Jalview speaking Spanish. :wink:

···

---------- Forwarded message ----------
From: Jim Procter <jprocter@compbio.dundee.ac.uk>
Date: 2014-10-06 21:51 GMT+02:00
Subject: Re: [Jalview-dev] Changes ready for test
To: Jalview Development List <jalview-dev@jalview.org>

Hello David.

On 06/10/2014 18:31, David Roldán Martínez wrote:

  1. i18n changes seems no to be merged. :frowning:
    hmm… really?
    My merge seems to have taken, so the more complete spanish translation
    is in both branches now.

http://source.jalview.org/gitweb/?p=jalview.git;a=shortlog;h=refs/heads/Release_2_8_2_Branch_i18n
http://source.jalview.org/gitweb/?p=jalview.git;a=shortlog;h=refs/heads/Release_2_8_2_Branch

  1. I’ve switched Release_2_8_2_Brach and tested JAL-1506. I’m getting
    an exception, not a warning dialog (please, see my comments at the
    ticket). However, I’m sure if this is the right branch I have to test.
    David - you needed to switch to the branch where Mungo pushed his
    changes for review. However, as I said in the previous email - I’m
    reviewing and merging these in, so you don’t need to do anything yet.

Jim

Jalview-dev mailing list
Jalview-dev@jalview.org
http://www.compbio.dundee.ac.uk/mailman/listinfo/jalview-dev

8

:smiley: we will most likely release at the end of the month, allowing for a bit more beta testing of the new features (once they're actually working !).

Jim

···

On 07/10/2014 07:13, David Roldán Martínez wrote:

I've reviewed i18n and everything seems to be ok. As for translations, I'll ping volunteers to check the status. At least for the Spanish one, if Ipek hasn't found the time to do it, I'll do it on my own so that we can arrive the release with Jalview speaking Spanish. :wink: