Code formatting and 'if blocks'

Jalview Developers
1

As touched on in this morning’s discussion:

I don’t think the Jalview code formatter has any effect on this.

For example in Annotation Panel there are

line 291

if (!av.getColumnSelection().isVisible(index))

continue;

line 408

if (!viscols.isVisible(index))

continue;

which are not changed by the formatter.

This would need to be enforced in ‘Java | Editor | Additional Save Actions’:

pastedImage.png

I’ll circulate a proposal for the options we should standardise on here.

Thanks,

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096

2

OK – if you want to commit a patch to the formatter that changes that style, go ahead, since it seems we’re not in the parallel universe where the Jalopy/Eclipse formatter did those (if it ever did ;p)

pastedImage.png

···

From: jalview-dev-bounces@jalview.org [mailto:jalview-dev-bounces@jalview.org] On Behalf Of Mungo Carstairs
Sent: 02 October 2014 13:22
To: Jalview Development List
Subject: [Jalview-dev] Code formatting and ‘if blocks’

As touched on in this morning’s discussion:

I don’t think the Jalview code formatter has any effect on this.

For example in Annotation Panel there are

line 291

if (!av.getColumnSelection().isVisible(index))

continue;

line 408

if (!viscols.isVisible(index))

continue;

which are not changed by the formatter.

This would need to be enforced in ‘Java | Editor | Additional Save Actions’:

I’ll circulate a proposal for the options we should standardise on here.

Thanks,

Mungo

The University of Dundee is a registered Scottish Charity, No: SC015096